Move authentication token registration to Shared Kernel #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjementum
force-pushed
the
pp-272-move-authentication-token-registration-to-shared-kernel
branch
from
43277ed to
4275e5c
Compare
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
|
tjementum
deleted the
pp-272-move-authentication-token-registration-to-shared-kernel
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Move the registration of authentication-related services to the Shared Kernel to allow self-contained systems to create authenticated HTTP clients in base tests. The following services are now registered in the Shared Kernel:
IPasswordHasher<object>OneTimePasswordHelperRefreshTokenGeneratorAccessTokenGeneratorAuthenticationTokenServiceAdditionally,
AddEmailSignatureClienthas been renamed toAddEmailClientfor improved clarity and consistency.Checklist